[feat] font customization improvements#109
Open
thisiskarrydev wants to merge 1 commit intoDaleHuntGB:mainfrom
Open
[feat] font customization improvements#109thisiskarrydev wants to merge 1 commit intoDaleHuntGB:mainfrom
thisiskarrydev wants to merge 1 commit intoDaleHuntGB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
New helper:
BCDM:ResolveElementFont(fontName)inCore/Globals.lua-- resolves a per-element font via LSM, falling back to the global media font if unset.Propagation logic:
PropagateGlobalFontSettings()inCore/GUI.lua-- when the global Font, Font Flag, or Font Colour is changed, it overwrites the corresponding setting on all cooldown viewer elements, power bars, cast bar text regions, and cooldown text. This allows a one-click global change while still permitting per-element overrides afterwards.Defaults: All elements now store
Font = "Friz Quadrata TT"andFontFlag = "OUTLINE"in their respectiveTexttables, matching the existing global defaults. Existing saved variables will pick up these new defaults automatically via AceDB.Module updates: All
SetFontcalls across 9 module files now read from per-elementText.FontandText.FontFlaginstead of the globalBCDM.Media.FontandGeneralDB.Fonts.FontFlag.Files Changed
Core/Defaults.lua-- new Font/FontFlag/Colour fields across all element Text tables + Trinket Text sectionCore/Globals.lua--ResolveElementFont()helperCore/GUI.lua-- Font/FontFlag dropdowns + ColourPickers for all element Text Settings, global propagation logic, global Font Colour pickerModules/CooldownManager.lua,CustomCooldownViewer.lua,AdditionalCustomCooldownViewer.lua,CustomItemViewer.lua,CustomItemSpellViewer.lua,TrinketBar.lua-- per-element font resolution for cooldown text and charge countsModules/PowerBar.lua,SecondaryPowerBar.lua,CastBar.lua-- per-element font resolution for bar textTest Plan